[MAJOR] Simplify the design #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcturan20
requested review from
caner-milko and
shamilatesoglu
and removed request for
caner-milko
caner-milko
reviewed
Jun 26, 2025
caner-milko
reviewed
Jun 26, 2025
caner-milko
reviewed
Jun 26, 2025
caner-milko
reviewed
Jun 30, 2025
shamilatesoglu
requested changes
Jun 30, 2025
caner-milko
reviewed
Jul 1, 2025
…nts (default is workspace for now)
caner-milko
approved these changes
Jul 7, 2025
|
Also, we can listen to |
shamilatesoglu
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges editor entry and file entry concepts. If an entry is registered and there is a matching entry in already read files, it immediately calls the Update callback. If there is not, tries to read one.