Skip to content

deps: update grpc to 1.84.0 - #567

Open
santigimeno wants to merge 1 commit into
santi/update_protobuffrom
santi/update_grpc
Open

santigimeno wants to merge 1 commit into
santi/update_protobuffrom
santi/update_grpc

Conversation

@santigimeno

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Santiago Gimeno <santiago.gimeno@gmail.com>
@santigimeno santigimeno self-assigned this Oct 9, 2026
@ns-control-tower

ns-control-tower commented Oct 9, 2026 •

Copy link
Copy Markdown

Walkthrough

This PR re-snapshots the vendored gRPC under deps/grpc/ to upstream gRPC 1.84.0 (codename gimbal), on top of the base branch's protobuf 36.2 update. All 1486 changed files live under deps/grpc/; no N|Solid-side integration code changed (agents/grpc/ is untouched). The diff is essentially a vendored snapshot swap plus the build-list maintenance that goes with it.

Key points:

  • Version markers are consistent and grounded. deps/grpc/Makefile:371 sets CPP_VERSION = 1.84.0; deps/grpc/src/core/lib/surface/version.cc:25 reports core 56.0.0 and :27 the codename gimbal, which matches the official upstream gRPC 1.84.0 ("gimbal") release — confirming the snapshot is a real upstream tag, not an ad-hoc tree.
  • deps/grpc/grpc.gyp (the hand-maintained N|Solid build list) tracks upstream file moves. It adds new sources (ext_proc and composite filters, telemetry, xDS TLS, the consolidated DNS resolver) and drops files upstream removed (c-ares DNS resolvers, resolve_address*, blackboard, decode_fast.c).
  • A new submodule is declared but not inlined. third_party/grpc-proto is added to deps/grpc/.gitmodules:56, but (like most gRPC submodules here — abseil, boringssl, protobuf, etc.) it is not vendored on disk. This is consistent with the existing vendoring pattern and is not needed at build time because the upb message code is pre-generated and checked into src/core/ext/upb-gen.

Assessment

Validated against a fresh clone of the PR head (aef3c1f) vs. the merge base (d33e23f, santi/update_protobuf):

  • Build-list internal consistency (verified). Every one of the 1096 source files referenced in deps/grpc/grpc.gyp exists on disk at the PR head (0 missing). Conversely, every file the gyp removed is actually gone from the tree — so no orphaned references and no dropped-but-still-needed units. The one "removed then re-added" entry (envoy/config/core/v3/cel.upbdefs.c) is a reorder, not a real removal.
  • New sources compile-ready (verified). Spot-checked all 31 newly-added .cc/.c entries in grpc.gyp — all present (e.g. src/core/transport/message_size_service_config.cc, src/core/filter/ext_proc/ext_proc_filter.cc, src/core/xds/grpc/xds_tls_context.cc).
  • Supply chain. gRPC 1.84.0 is a published upstream release; the vendored version string matches. No new build-time network fetches or install scripts were introduced by the nsolid-side changes. The new grpc-proto submodule URL is the official grpc/grpc-proto.git.
  • CI. Combined commit status on the head is pending (no statuses reported yet) — I could not validate the build via CI. Build correctness ultimately depends on the full nsolid compile and on gRPC 1.84.0 ↔ protobuf 36.2 compatibility; the author is driving both bumps in sequence (this PR's base is the protobuf-update branch), so they appear coordinated.

No blocking correctness, security, or performance findings. The change is a routine vendored dependency bump with a consistently maintained build list.

Verdict: APPROVE — clean vendored gRPC re-snapshot; build list verified internally consistent. Advisory only — does not replace required human review, and CI has not yet run.

overview
build-list
submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants