chore: update CI to include build+test:headless #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some of the dependabot / snyk PRs could update dependencies like webpack and friends, these checks should be included for pull requests. Signed-off-by: Lance Ball <lball@redhat.com>
|
Huh looks like this caught itself. I was using Node.js 16 for this PR, but apparently a change in 18 breaks the browser build. |
Signed-off-by: Lance Ball <lball@redhat.com>
This commit modifies CI so that the build matrix only uses the two previous releases, and runs a separate action for `current` (18x at the moment). This is because some things changed in Node.js 18 and I need to set an environment variable when building to avoid error. However, setting this environment variable results in an error for older versions of Node.js. Signed-off-by: Lance Ball <lball@redhat.com>
helio-frota
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some of the dependabot / snyk PRs could update dependencies like webpack and friends, these checks should be included for pull requests.
Signed-off-by: Lance Ball lball@redhat.com