feat: provide an Iterator of all active circuits #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CircuitBreaker object keeps a Set of instances that have been created. This change makes a Set Iterator of all circuits that have not been <code>shutdown()</code>. Fixes: #340
lholmquist
reviewed
Jun 25, 2019
| @@ -2,7 +2,7 @@ | |||
| <html> | |||
| <head> | |||
| <meta charset='utf-8' /> | |||
| <title>opossum 2.1.0 | Documentation</title> | |||
| <title>opossum 2.2.0 | Documentation</title> | |||
There was a problem hiding this comment.
weird that wasn't updated during the npm run release
There was a problem hiding this comment.
I should add to CONTRIBUTING.md that before releasing you need to run npm run build:docs - or maybe that should be added as a prerelease task.
helio-frota
approved these changes
Jun 25, 2019
lholmquist
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CircuitBreaker object keeps a Set of instances that have been
created. This change makes a Set Iterator of all circuits that have
not been
shutdown().Fixes: #340