process.uptime is not a function

[dptoot]

Node.js Version: 10.15.3

Operating System: Windows

Steps to Produce Error:

Just including the opossum library in our SSR application causes:

processStartTime.js?43bd:4 Uncaught TypeError: process.uptime is not a function
    at Object.eval (processStartTime.js?43bd:4)
    at eval (processStartTime.js:30)
    at Object.../../packages/bonnet/node_modules/prom-client/lib/metrics/processStartTime.js (client.js:4939)
    at __webpack_require__ (client.js:770)
    at fn (client.js:130)
    at eval (defaultMetrics.js?9dd3:4)
    at Object.../../packages/bonnet/node_modules/prom-client/lib/defaultMetrics.js (client.js:4731)
    at __webpack_require__ (client.js:770)
    at fn (client.js:130)
    at eval (index.js?875d:22
)

No actual circuit breaker has been defined yet.

From a new relic post
https://discuss.newrelic.com/t/process-uptime-is-not-a-function/65486
It appears there is server-side code being called in our clietn bundle now. Any resolutions?

[lholmquist]

@dptoot What version of Opossum are you using? How are you including in your application?

[dptoot]

@lholmquist Thanks for the quick response.

opossum@3.0.0

At this point it was just including the opossum module in my file that caused the error when bundled

import 'isomorphic-unfetch';
import URL from 'url-parse';
import circuitBreaker from 'opossum';

Currently passed the import I am not referencing opossum yet.

[dptoot]

This file is bundled within the server and client bundles via webpack.

[dptoot]

I did look into using the format

import circuitBreaker from 'opossum/dist/opossum';

as described in the create-react-app issue: #361

but that cause a server-side build issue

ReferenceError: window is not defined
at Object.<anonymous> (C:\Users\jelewis1\work\bonnet\node_modules\opossum\dist\opossum.js:10:4)
at Module._compile (internal/modules/cjs/loader.js:701:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
at Module.load (internal/modules/cjs/loader.js:600:32)
at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
at Function.Module._load (internal/modules/cjs/loader.js:531:3)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at Object.opossum/dist/opossum (C:\Users\jelewis1\work\bonnet\examples\bonnet-poc\build\server\js\server.js:8848:18)
at __webpack_require__ (C:\Users\jelewis1\work\bonnet\examples\bonnet-poc\build\server\js\server.js:692:30)

[dptoot]

side note... being that we don't plan on using prometheus is there not a way to opt out of this functionality being loaded?

[lholmquist]

We are in the process of trying to make that optional, see #350

what about this comment. #361 (comment) , would that help for the time being?

[dptoot]

Thanks for the help. I have been trying to follow that but we have some complex nodeExternals config going on that maybe conflicting.

I see there is some approvals on #350. Is there a timeline on this? I would love to include this module in our app.

[dptoot]

I think the issue I am having with externals is the code is still referencing it? If I push to prod mode with prom-client in externals then I just get a prom is not defined error:

client.45038fa1.min.js:8 Uncaught ReferenceError: prom is not defined

[dptoot]

I have been able to get server side running by removing opossum completely from the client bundle with a browser setting in the package.json.

browser: {
 "opossum": false
}

Obviously this is non-optimal. Doing this for the prom-client creates the scenario described in #361.

[helio-frota]

Maybe non-optimal because you are mixing "bundle configuration" in package.json and webpack right?

But I think for the case you described that seems a good workaround, until wait for the future updates.

[dptoot]

@helio-frota I would say non-optimal as we now don't have circuit-breaking in the browser at all until the future updates are in place :(

Thanks for all the help on this guys

[dptoot]

I know you guys have got it handled but I added the opossum include to a bare create-next-app installation. First saw the issue from #361 and then after removing prom-client from externals I get the no prom error. Feel free to use this if you need a SSR example.

https://github.com/dptoot/next-js-opossum

This is where we are adding opossum. Which would now be bundled on the server and client.
https://github.com/dptoot/next-js-opossum/blob/master/pages/index.js#L5

[dptoot]

Current solution was to roll opossum back to v1.11.0. It works great! Just looking foward to being able to use v2 and above once these metric plugins are externalized. Thanks guys!

[lance]

@dptoot glad you got things worked out! My PR #350 should land soon, and we'll be pushing out a 4.0 release shortly afterwards. I'm going to close this issue for now, since you have a workaround, and we have a pending fix.