Skip to content

Commit

Permalink
run linting through turbo, include in ci
Browse files Browse the repository at this point in the history
  • Loading branch information
cdriesler committed Apr 5, 2023
1 parent ea72a65 commit 185ce71
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-converters.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: ci-converters
name: converters

on: [push]

jobs:
build-converters:
build:
name: build-converters
runs-on: ubuntu-latest

Expand Down
36 changes: 30 additions & 6 deletions .github/workflows/ci-nodes.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
name: ci-nodes
name: nodes

on: [push]

jobs:
build-nodes:
name: build-nodes

build:
name: build
runs-on: ubuntu-latest

steps:
Expand All @@ -17,6 +18,29 @@ jobs:
run: npm ci
- name: Build packages
run: npm run build:ci
- name: Run tests
working-directory: packages/nodes/
run: npm run test

lint:
name: lint
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
cache: "npm"
- name: Lint packages
run: npm run lint:ci

test:
name: test
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
cache: "npm"
- name: Lint packages
run: npm run test:ci
2 changes: 1 addition & 1 deletion apps/nodepen-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"build": "next build",
"start": "next start",
"lint": "next lint",
"link:react": "npm link ../../../node_modules/react"
"test": "echo \"ok\""
},
"dependencies": {
"@nodepen/core": "^1.1.0",
Expand Down
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
"dev": "npx turbo run dev --no-daemon",
"dev:speckle": "cd apps/speckle-server && yarn dev:docker:up && yarn dev",
"dev:rhino": "cd apps/rhino-compute-server && dotnet watch",
"lint": "npx turbo run lint --no-daemon"
"lint": "npx turbo run lint --no-daemon --concurrency=1",
"lint:ci": "npx turbo run lint --no-daemon --concurrency=1 --filter=!./apps/*",
"test": "npx turbo run test --no-daemon",
"test:ci": "npx turbo run test --no-daemon --filter=./packages/nodes"
},
"devDependencies": {
"@types/mocha": "^10.0.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"scripts": {
"build": "tsc",
"dev": "tsc -w --preserveWatchOutput",
"lint": "eslint --ext .ts,.tsx ."
"lint": "eslint --ext .ts,.tsx .",
"test": "echo \"ok\""
}
}
3 changes: 2 additions & 1 deletion turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"dev": {
"cache": false
},
"lint": {}
"lint": {},
"test": {}
}
}

0 comments on commit 185ce71

Please sign in to comment.