Fixes net.ifinfo failure
#3267
Merged
Fixes net.ifinfo failure
#3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelstoer
reviewed
Sep 1, 2020
|
Looks right to me. @vsky279 Can I get you to squash the two commits together yourself so we can do the "rebase and merge" rather than "squash and merge" that will, I think, leave my name on it rather than yours and @marcelstoer's? |
Hhmm, what makes you think so? Git(Hub) just records the committer separately from the author if you "squash and merge": https://github.com/nodemcu/nodemcu-firmware/commits/dev. Looks all dandy to me. |
|
It's squashed now :-) |
|
All my tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3249.
devbranch rather than formaster.docs/*.This seems to be an easy catch. Only 0 or 1 are eligible parameters to
eagle_lwip_getifanddhcptable can be added to the resulting table only whendhcptable is created.