Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqlite3 module #3123

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Remove sqlite3 module #3123

merged 1 commit into from
Jun 10, 2020

Conversation

nwf
Copy link
Member

@nwf nwf commented May 23, 2020

It's not clear that this ever worked, AFAICT nobody uses it, and it's an old version of the sqlite3 engine at this point. Absent a maintainer, let's just get rid of it after this master cuts (#3066).

"Fixes" #2913 and #2300

@TerryE
Copy link
Collaborator

TerryE commented May 23, 2020

If none of the other committers objects strongly, then I'll merge this in a day or so.

@nwf
Copy link
Member Author

nwf commented May 24, 2020

How about we cut master (and close #3066) and then merge this? Gives us time to back it out if someone does object.

@TerryE
Copy link
Collaborator

TerryE commented May 24, 2020

I feel that I need to do some extra work checking out telnet and FTP server against Dev before we cut to master, and I also feel that this and the cut to master are independent issues.

@HHHartmann
Copy link
Member

I would also want to wait til after the master cut. That way we have our discontinuation note in the docs for one cycle.
OTOH nobody really seems to miss it really.

@marcelstoer
Copy link
Member

I feel that I need to do some extra work checking out telnet and FTP server against Dev before we cut to master

👍

I would also want to wait til after the master cut.

👍

It's not clear that this ever worked, AFAICT nobody uses it, and it's an
old version of the sqlite3 engine at this point.  Absent a maintainer,
let's just get rid of it.
@nwf nwf merged commit 35a266e into nodemcu:dev Jun 10, 2020
@nwf nwf deleted the rm-sqlite3 branch June 10, 2020 01:14
@marcelstoer marcelstoer added this to the Next release milestone Jun 10, 2020
@marcelstoer
Copy link
Member

Missing: removal of sqlite3.md from mkdocs.yml. Now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants