Skip to content

Fix gpio.serout heap management #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2018
Merged

Fix gpio.serout heap management #2220

merged 1 commit into from
Jan 10, 2018

Conversation

@devsaurus
Copy link
Member

@devsaurus devsaurus commented Jan 4, 2018

Fixes #2216.

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.

lgpio_serout() was missing to set serout.delay_table to NULL at the end of a synchronous operation. This triggered the 3ffef6c8 already freed error message for the subsequent operation as reported in #2216.

@marcelstoer marcelstoer added this to the 2.1 follow-up II milestone Jan 8, 2018
@marcelstoer marcelstoer merged commit fc2f325 into nodemcu:dev Jan 10, 2018
@devsaurus devsaurus deleted the serout_free branch January 10, 2018 20:53
dnc40085 pushed a commit to dnc40085/nodemcu-firmware that referenced this pull request Mar 3, 2018
@devsaurus @marcelstoer
add missing NULLification of serout.delay_table after luaM_freearray() (
40c7a8e 
nodemcu#2220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjsg pjsg pjsg approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@devsaurus @pjsg @marcelstoer