Conversation
|
CC @nodejs/TSC |
|
The issue didn't even pass and you're opening a PR already? 🫠 |
|
The issue received 5 approvals and no objections after 72 hours, which I believe qualifies as a pass. I believe this aligns with the typical process for administrative changes as outlined in the nodejs/admin repo |
|
I'd consider it passing once it gets closed no? |
|
No? I would assume that the issue gets closed when the action gets taken to resolve it. i.e. a Node.js Core Collaborator nomination issue is closed by the PR to add the nominee, not when the nomination passes. |
|
Bump @nodejs/TSC |
This comment was marked as outdated.
This comment was marked as outdated.
|
We need a tsc-agenda to add this to the TSC agenda. To clarify for @nodejs/tsc we want the web-standards team to be removed from the @nodejs/web group and just be added diredctly to the same level all other "technical teams" for pining @ nodejs/node are. |
This comment was marked as resolved.
This comment was marked as resolved.
SGTM (or that was what I thought how it worked in the first place). |
|
Hey TSC! A lot of yall have approved this, but we still need you to remove the team as a child, as defined in the PR description, can you please do that? Once it's done, feel free to remove the agenda and blocked label. |
|
Looks like nobody objects after a month. Going to push the button. |
|
I moved |
|
Oops, this should be merged, not closed. Not sure if simply pushing the merge button here would suffice. @avivkeller feel free the push the button. |
Closes #10.
Before merging this, the following steps are required: