Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change loong64 architecture gcc version #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wojiushixiaobai
Copy link

@wojiushixiaobai wojiushixiaobai commented Oct 1, 2024

image

Signed-off-by: 吴小白 <296015668@qq.com>
@rvagg
Copy link
Member

rvagg commented Oct 1, 2024

What is this fixing? Is it currently broken?
Node.js currently requires 12 so going backward would seem like a bad idea: https://github.com/nodejs/node/blob/main/BUILDING.md#supported-toolchains

@wojiushixiaobai
Copy link
Author

wojiushixiaobai commented Oct 1, 2024

@rvagg
Doesn't work on some older systems, modified to the same version as riscv64.

644c227260c5ceb3755fcdbda8a88f81

Maybe we can configure it according to the gcc version requirements of node.

# run.sh
MAJOR_VERSION=$(echo ${fullversion} | cut -d . -f 1 | tr --delete v)

export CC_host="ccache gcc-12"
export CXX_host="ccache g++-12"

if [ $MAJOR_VERSION -lt 22 ]; then
  export CC_host="ccache gcc-10"
  export CXX_host="ccache g++-10"
fi

if [ $MAJOR_VERSION -lt 20 ]; then
  export CC_host="ccache gcc-8"
  export CXX_host="ccache g++-8"
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants