Repository navigation
fix(mock): expose aborted on the mock dispatch controller - #5964
Open
santiago-su wants to merge 1 commit into
Open
santiago-su wants to merge 1 commit into
santiago-su wants to merge 1 commit into
Conversation
santiago-su
force-pushed
the
fix/mock-agent-redirect-aborted
branch
from
October 5, 2026 12:23
4c59904 to
a54f1b2
Compare
Author
|
force pushed because I didn't have my GPG keys setup in this machine 😀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5964 +/- ##
==========================================
+ Coverage 86.11% 86.13% +0.01%
==========================================
Files 115 115
Lines 45723 45730 +7
==========================================
+ Hits 39376 39389 +13
+ Misses 6347 6341 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to #5963
Rationale
Since #5850,
onResponseErrorinlib/web/fetch/index.jscheckscontroller.abortedbefore terminating the fetch. The controller built bydispatchMockReplyhad noabortedproperty, so redirects followed throughMockAgentfailed withRequest was cancelled..Changes
Bug Fixes
abortedgetter to the mock dispatch controller inlib/mock/mock-utils.js.test/mock-agent.js(MockAgent - fetch follows a redirect).Features
N/A
Breaking Changes and Deprecations
N/A
Status