fix: set finalizer only for fetch responses #4803
Merged
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
=======================================
Coverage 93.23% 93.24%
=======================================
Files 109 109
Lines 34100 34101 +1
=======================================
+ Hits 31793 31797 +4
+ Misses 2307 2304 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsctx
force-pushed
the
fix/set-finalizer-only-fetch
branch
from
b179440 to
0d2e8f7
Compare
tsctx
force-pushed
the
fix/set-finalizer-only-fetch
branch
from
0d2e8f7 to
d9ad450
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4713 (comment)
I found that I was overlooking this part.
In the past, I added a finalizer after cloning all responses. However, doing so on unfetched responses resulted in unreachable code, making it inefficient.