webidl: fix existing and add missing buffer source converters #4503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Aims to provide support for a resolution for #4495.
Rationale
Factors contributing to the specification divergence for fetch/websockets as detailed in the linked issue are:
Changes
Changes to existing converters:
ArrayBufferused to convert to eitherArrayBufferorArrayBuffer | SharedArrayBuffer, depending on the presence or absence of the[AllowShared]attribute. Subsequent changes to the standard have separated these out into separate IDL types, and so this converter has been split into two.ArrayBufferandSharedArrayBufferconverters correctly handle the presence or absence of the[AllowResizable]attribute.[AllowShared]and[AllowResizable]attributes.New converters:
ArrayBufferViewBufferSourceAllowSharedBufferSourceBreaking Changes and Deprecations
As mentioned, this does not affect the current behaviour of undici web APIs, as they do not use these converters at present.
Status