fix(h2): adjust :scheme on h2 requests #4454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
commented
Aug 24, 2025
Uzlopak
reviewed
Aug 24, 2025
Uzlopak
reviewed
Aug 24, 2025
Uzlopak
reviewed
Aug 24, 2025
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
metcoder95
commented
Aug 25, 2025
Uzlopak
approved these changes
Aug 27, 2025
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
We can take care of performance issues some other time.
mcollina
previously requested changes
Aug 29, 2025
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
no new URL in the hot path. It got incredibly faster, but it's still a very complex algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Adjust the pseudo header
:schemein accordance to the actual protocol used (support for h2c client).Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status