Skip to content

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Aug 8, 2025

This relates to...

Closes #4156

Rationale

Changes

  • test: fix key-size pem errors
  • chore: use @metcoder95/https-pem

Features

Bug Fixes

Breaking Changes and Deprecations

Status

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 9, 2025

Oh, i also created a PR #4400

I actually prefer mine, because it removes a dependency and does not replace it.

@gurgunday
Copy link
Member

Honestly I'd also prefer inlining but just my 50c

@metcoder95
Copy link
Member Author

I don't have a strong opinion on this; the good reason I found to keep something like https-pem is removal of the manual work to do rotation of certificates every no and then, as well as to test several key sizes and other combinations to detect possible regressions.

But if we feel otherwise, happy to go with an inline version

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The reason we didn't go for inline certs is to avoid the PRs needed to update them every X amount of time + all the false positives that security scanners would generate.

@Uzlopak Uzlopak merged commit 8dd120e into main Aug 11, 2025
32 of 33 checks passed
@Uzlopak Uzlopak deleted the fix-h2-cio branch August 11, 2025 06:07
@github-actions github-actions bot mentioned this pull request Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error:0A00018F:SSL routines::ee key too small in tests using modern openssl
5 participants