MockAgent.prototype.get support ignoreTrailingSlash option #4344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
LGTM with some minor nits about seemingly unrelated formatting and test changes.
test/jest/mock-agent.test.js
Outdated
| /* global describe, it, afterEach, expect */ | ||
|
|
||
| describe('MockAgent', () => { | ||
| describe('smoking test in jest', () => { |
Collaborator
There was a problem hiding this comment.
I don't think this should be renamed
lib/mock/mock-agent.js
Outdated
Comment on lines
25
to
29
| const { | ||
| matchValue, | ||
| normalizeSearchParams, | ||
| buildAndValidateMockOptions | ||
| } = require('./mock-utils') |
Collaborator
There was a problem hiding this comment.
There looks to be some formatting changes included in here. Is this actually from the formatter in the repo or something else?
Contributor
Author
There was a problem hiding this comment.
It might be my editor. My neovim config includes auto-formatting with prettier and eslint.
Contributor
Author
|
@Ethan-Arrowood @metcoder95 All done. |
Ethan-Arrowood
approved these changes
Jul 18, 2025
metcoder95
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
fix #4342
Rationale
Changes
MockAgent.prototype.get now respect the
ignoreTrailingSlashoption.Features
Bug Fixes
Breaking Changes and Deprecations
Status