Merged
Conversation
gurgunday
approved these changes
May 18, 2025
Member
|
can you please merge main or rebase? Should fix CI |
styfle
force-pushed
the
styfle/fix-memory-leak-dispatcher
branch
from
dea2cd2 to
7117600
Compare
Member
Author
Hmm, the failure looks unrelated to my PR 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
There was a TODO introduced in a previous PR:
Rationale
There is a known memory leak
Changes
Track the number of origins per dispatcher, then clean up when that reaches 0 in order to avoid the memory leak.
You may not notice this memory leak if you don't fetch from many different origins.
Features
N/A
Bug Fixes
Breaking Changes and Deprecations
N/A
Status