fix(#3736): back-port 183f8e9 to v6.x#3855
Merged
ronag merged 2 commits intonodejs:v6.xfrom Nov 21, 2024
Merged
Conversation
Contributor
Author
|
Test failures seem limited to Node 22 and TLS behaviour, not the substance of the PR: |
Contributor
Author
|
OK I found #3769 which addresses a change change in error messages in Node v22. I backported the fix and hope tests now pass. |
KhafraDev
approved these changes
Nov 20, 2024
ronag
requested changes
Nov 21, 2024
Member
ronag
left a comment
There was a problem hiding this comment.
The user should have an error handler registered...
ronag
approved these changes
Nov 21, 2024
Member
ronag
left a comment
There was a problem hiding this comment.
not sure I agree with this but it seems I approved the other one...
metcoder95
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
This applies the changes in #3740 that failed automatic backport into
v6.x. Our testing suggests that this resolves #3848.Rationale
Changes
Adds a no-op
"error"event handler to theresstream when handlingAbortSignalaborts inrequest()that was otherwise leading to process-level uncaught exceptions in our codebase.Features
N/A
Bug Fixes
Fixes #3736 in v6.x
Fixes #3848 in v6.x
Breaking Changes and Deprecations
Status
test/issue-3356.jstimes out with this change undernpm testbut not if run directly vianode test/issue-3356.js.