Skip to content

set ws readyState if closed before connection could be established #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KhafraDev merged 1 commit into from
Oct 8, 2024
Merged

set ws readyState if closed before connection could be established #3701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/web/websocket/websocket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,8 @@ class WebSocket extends EventTarget {
}

if (!this.#handler.wasEverConnected) {
this.#handler.readyState = states.CLOSED

// If the WebSocket connection could not be established, it is also said
// that _The WebSocket Connection is Closed_, but not _cleanly_.
fireEvent('close', this, (type, init) => new CloseEvent(type, init), {
Expand Down
15 changes: 15 additions & 0 deletions test/websocket/issue-3697-2399493917.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
'use strict'

const { test } = require('node:test')
const { WebSocket } = require('../..')
const { tspl } = require('@matteo.collina/tspl')

// https://github.com/nodejs/undici/issues/3697#issuecomment-2399493917
test('closing before a connection is established changes readyState', async (t) => {
const { completed, strictEqual } = tspl(t, { plan: 1 })

const ws = new WebSocket('wss://example.com/non-existing-url')
ws.onclose = () => strictEqual(ws.readyState, WebSocket.CLOSED)

await completed
})