Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop blocking #3495

Merged
merged 8 commits into from
Aug 27, 2024
+714 −160
Merged

fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop blocking #3495

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a36e184
fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop …
Uzlopak Aug 23, 2024
50cc05d
also test native timers
Uzlopak Aug 23, 2024
4c75ee3
Merge branch 'main' into refactor-fast-timers
Uzlopak Aug 24, 2024
5f275eb
improve the commentary of fasttimers
Uzlopak Aug 24, 2024
b802be6
revert changes in client-h1.js
Uzlopak Aug 24, 2024
ad339a2
make fasttimers independent from performance.now
Uzlopak Aug 25, 2024
33fe101
less flaky?
Uzlopak Aug 25, 2024
246f120
Merge branch 'main' into refactor-fast-timers
Uzlopak Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into refactor-fast-timers
  • Loading branch information
@Uzlopak
Uzlopak authored Aug 27, 2024
commit 246f1203865e67466f66db71cfa173d1b31ab9a1
2 changes: 1 addition & 1 deletion lib/dispatcher/client-h1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class Parser {
if (delay !== this.timeoutValue) {
this.timeout && timers.clearTimeout(this.timeout)
if (delay) {
this.timeout = timers.setTimeout(onParserTimeout, delay, this)
this.timeout = timers.setTimeout(onParserTimeout, delay, new WeakRef(this))
// istanbul ignore else: only for jest
if (this.timeout.unref) {
this.timeout.unref()
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.