fix: tick timer instead of using Date.now #3494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm generically ok with the change, but I would be happier with tests. Maybe one from @Uzlopak's PR? |
|
I suspect that pr includes this change somewhere |
|
This PR is replacing the Date.now() call with saying that every time setTimeout is triggered that 499 ms are passed. This means, that if the event loop blocks for e.g. 900ms, we still "think" that just 499ms passed. So the fasttimer will be artificially delayed. |
|
We could change it in my PR to just increment the fastNow value instead of calling performance.now. But somehow it feels wrong. |
|
The whole point is that we don't want to include event loop delay |
|
adapted with unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes some of the timeout issues we have been facing. Again needs work with tests.
Refs: #3493
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status