-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): properly redirect non-ascii location header url #2971
Merged
mcollina
merged 8 commits into
nodejs:main
from
Xvezda:fix/redirect-non-ascii-location-header
Mar 21, 2024
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e07ade3
fix(fetch): properly redirect non-ascii location header url
Xvezda 48fd3c1
chore: fix typo
Xvezda 01ceae8
test: use simpler code
Xvezda 6d5f770
chore: clarify what the code does
Xvezda ea34bc2
chore: add comment
Xvezda efccdde
chore: normalize location url only if it contains invalid character
Xvezda 45f2e48
chore: apply suggestion
Xvezda 3519ca1
chore: remove redundant condition check
Xvezda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems strange to me:
Buffer.from(location, 'ascii').toString('utf8')
. I suggest at least some comments to explain what the intention is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec links "parsing" to https://url.spec.whatwg.org/#concept-url-parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lemire
This issue arises when the location header's address is not encoded as with
encodeURI
, but is responded in binary form.For example, while the result of
encodeURIComponent('안녕')
is%EC%95%88%EB%85%95
, in binary form, this appears as\xEC\x95\x88\xEB\x85\x95
, same as the outcome ofBuffer.from('안녕', 'utf8').toString('binary')
.What I am attempting in this code is to normalize characters that exist outside the ASCII range into UTF-8 form and URL encode them, to ensure behavior consistent with major web browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KhafraDev Yes. Parsing with the base will work the same in ada, test here : ada-url/ada#611