Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't rely on allowSyntheticDefaultImports #1059

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: don't rely on allowSyntheticDefaultImports #1059

merged 1 commit into from
Oct 13, 2021

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Oct 12, 2021

This PR contains changes that correspond with the best practices for default imports set forth in the DefinitelyTyped documentation. Please refer to "esModuleInterop/allowSyntheticDefaultImports" for more information.

Fixes #1058

@ronag ronag requested a review from Ethan-Arrowood October 12, 2021 14:41
@mcollina
Copy link
Member

@fox1t wdyt?

Copy link
Collaborator

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Since the type tests still pass I'm confident with the change. Im not sure if there is an easy way to test both ESM/CJS importing for TypeScript, but if there is that would be a useful addition to this PR

@mcollina mcollina merged commit c338761 into nodejs:main Oct 13, 2021
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level functions aren't typed correctly
3 participants