Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate releases (v5) #3103

Open
mweberxyz opened this issue Apr 12, 2024 · 1 comment · May be fixed by #3110
Open

automate releases (v5) #3103

mweberxyz opened this issue Apr 12, 2024 · 1 comment · May be fixed by #3110
Labels
enhancement New feature or request

Comments

@mweberxyz
Copy link
Contributor

mweberxyz commented Apr 12, 2024

Given that this repo regularly has both 6.x and 5.x releases, and the 5.x branch gets significantly more traffic from npm, it would be best to extend the release workflows to support both branches.

I also realize it was a mistake in #3089 is to assume that the current release always immediately succeeds the last published release (ie- using releases[0] as the previous_tag_name in the calls to generateReleaseNotes) which means a 6.x release following a 5.x release (or vice versa) will wreck the release notes.

@mcollina thoughts? I think it would be easier to take care of both of these tasks at the same time, otherwise let me know and I'll pull out the secondary concern into it's own issue.

@mweberxyz mweberxyz added the enhancement New feature or request label Apr 12, 2024
@mcollina
Copy link
Member

go ahead and send a PR over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants