UND_ERR_HEADERS_TIMEOUT received even when setting a larger headersTimeout in dispatcher for fetch() #1864

Activity

1. xconverge

   added

   bugSomething isn't workingSomething isn't working

   on Jan 19, 2023
2. mcollina commented on Jan 19, 2023

   

   mcollina

   on Jan 19, 2023

   SponsorMember

   More actions

   How is the agent instantiated?
3. xconverge commented on Jan 19, 2023

   

   xconverge

   on Jan 19, 2023

   Last edited by xconverge

   ContributorAuthor

   More actions

   How is the agent instantiated?

   I just got this sample working to reproduce the issue. Changing the delay at the top to less than 4 is fine, and greater than 5 minutes and it fails

   I was able to do this same test with a Client and it seems to work fine, so something specific to fetch() I think

   "use strict";
   
   const { test } = require("tap");
   
   const { Agent } = require("../../");
   const { createServer } = require("http");
   const FakeTimers = require("@sinonjs/fake-timers");
   
   // When this is set to less than 4 it works, when set to 5 or greater it fails and returns a header error
   const minutes = 6;
   
   const msToDelay = 1000 * 60 * minutes;
   
   test("Realllly long for a single fetch()", (t) => {
     t.plan(1);
   
     const clock = FakeTimers.install();
     t.teardown(clock.uninstall.bind(clock));
   
     const server = createServer((req, res) => {
       setTimeout(() => {
         res.end("hello");
       }, msToDelay);
       clock.tick(msToDelay + 1);
     });
     t.teardown(server.close.bind(server));
   
     server.listen(0, () => {
       fetch(`http://localhost:${server.address().port}`, {
         path: "/",
         method: "GET",
         dispatcher: new Agent({
           headersTimeout: 0,
           connectTimeout: 0,
           bodyTimeout: 0,
         }),
       })
         .then((response) => response.text())
         .then((response) => {
           t.equal("hello", response);
           t.end();
         })
         .catch((err) => {
           console.error(err);
           t.error(err);
         });
   
       clock.tick(msToDelay - 1);
     });
   });
   
   
4. xconverge commented on Jan 19, 2023

   

   xconverge

   on Jan 19, 2023

   Last edited by xconverge

   ContributorAuthor

   More actions

   versus this (just substituted fetch() and agent with a client) which runs "fine"

   "use strict";
   
   const { test } = require("tap");
   
   const { Client } = require("../..");
   const { createServer } = require("http");
   const FakeTimers = require("@sinonjs/fake-timers");
   
   // When this is set to less than 4 it works, when set to 5 or greater it fails and returns a header error
   const minutes = 6;
   
   const msToDelay = 1000 * 60 * minutes;
   
   test("Realllly long for a single request", (t) => {
     t.plan(2);
   
     const clock = FakeTimers.install();
     t.teardown(clock.uninstall.bind(clock));
   
     const server = createServer((req, res) => {
       setTimeout(() => {
         res.end("hello");
       }, msToDelay);
       clock.tick(msToDelay + 1);
     });
     t.teardown(server.close.bind(server));
   
     server.listen(0, () => {
       const client = new Client(`http://localhost:${server.address().port}`, {
         headersTimeout: 0,
         connectTimeout: 0,
       });
       t.teardown(client.destroy.bind(client));
   
       client.request({ path: "/", method: "GET" }, (err, response) => {
         t.error(err);
         const bufs = [];
         response.body.on("data", (buf) => {
           bufs.push(buf);
         });
         response.body.on("end", () => {
           t.equal("hello", Buffer.concat(bufs).toString("utf8"));
         });
       });
   
       clock.tick(msToDelay - 1);
     });
   });
   
   
5. xconverge commented on Jan 19, 2023

   

   xconverge

   on Jan 19, 2023

   ContributorAuthor

   More actions

   Also here is what I am testing with locally https://github.com/xconverge/undici/commit/de7f4c0f404f5db4c5463a985e4143a5a895911c
6. xconverge commented on Jan 19, 2023

   

   xconverge

   on Jan 19, 2023

   Last edited by xconverge

   ContributorAuthor

   More actions

   PR opened for this.

   ❤️React with ❤️1Reacted by Matteo Collina
7. mcollina commented on Jan 20, 2023

   

   mcollina

   on Jan 20, 2023

   SponsorMember

   More actions

   Thanks!
8. mcollina

   closed this as completedin #1870on Jan 20, 2023