lib: fix Host header when CONNECT ProxyAgent (#2556)

nodejs · Dec 28, 2023 · 38824d0 · 38824d0
1 parent ee37cb0
commit 38824d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/proxy-agent.js b/lib/proxy-agent.js
@@ -66,7 +66,7 @@ class ProxyAgent extends DispatcherBase {
     this[kProxyHeaders] = opts.headers || {}
 
     const resolvedUrl = new URL(opts.uri)
-    const { origin, port, host, username, password } = resolvedUrl
+    const { origin, port, username, password } = resolvedUrl
 
     if (opts.auth && opts.token) {
       throw new InvalidArgumentError('opts.auth cannot be used in combination with opts.token')
@@ -97,7 +97,7 @@ class ProxyAgent extends DispatcherBase {
             signal: opts.signal,
             headers: {
               ...this[kProxyHeaders],
-              host
+              host: requestedHost
             }
           })
           if (statusCode !== 200) {

diff --git a/test/proxy-agent.js b/test/proxy-agent.js
@@ -393,7 +393,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', async
   }
 
   const expectedProxyHeaders = {
-    host: `localhost:${proxy.address().port}`,
+    host: `localhost:${server.address().port}`,
     connection: 'close'
   }