Skip to content
This repository has been archived by the owner on May 13, 2019. It is now read-only.

coverage: translate info into WIP scripts #46

Closed
wants to merge 1 commit into from

Conversation

Fishrock123
Copy link

Some things still don't work though...

I couldn't get gcov to work, and grep -o doesn't work with +/* in the
regex for me

cc @addaleax & @mhdawson

Some things still don't work though...

I couldn't get gcov to work, and grep -o doesn't work with +/* in the
regex for me
@addaleax
Copy link
Member

addaleax commented Dec 5, 2016

Just for reference, the original scripts are still available at https://github.com/addaleax/node-core-coverage

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

I can't quite decode your title "translate info into WIP scripts". You are trying to create scripts that can be run outside the build environment ?

@Fishrock123
Copy link
Author

You are trying to create scripts that can be run outside the build environment ?

@mhdawson Yes but ideally both?

Coverage is... a lot less useful unless you can also run it locally...

@mhdawson
Copy link
Member

mhdawson commented Dec 7, 2016

Agreed, my goal is to get us to "make coverage" as the way to build/run coverage and @CurryKitten is working to pull more of the pieces needed for that into the core. I'll try to catch up with him to see how far away we are on that front.

@CurryKitten
Copy link

As @mhdawson mentioned, I'm working on some additional changes which will effectively give you a coverage result from running make so a developer will be able to see what impact a code change/fix/new test has on the overall coverage result. Next action is to add Javascript coverage into the build.

@Fishrock123
Copy link
Author

@CurryKitten Is your work on a public repo somewhere?

@CurryKitten
Copy link

@Fishrock123 I'll push my code into my fork (https://github.com/CurryKitten/node) before I make a PR. Should have something ready next week, but I'll let you know

@Trott
Copy link
Member

Trott commented Sep 28, 2017

Now that we have make coverage, should this be closed?

@gibfahn
Copy link
Member

gibfahn commented Sep 30, 2017

Now that we have make coverage, should this be closed?

Seems like it, if not it can be reopened.

@gibfahn gibfahn closed this Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants