This repository was archived by the owner on May 13, 2019. It is now read-only.
This repository was archived by the owner on May 13, 2019. It is now read-only.
Review the use of timeouts #19
Closed
Description
I'm not sure if this deserves an issue or if there's anything actionable, but anyway...
Lately, most of the failing tests I've found: nodejs/node#5342, nodejs/node#5339, nodejs/node#5129 were flaky because of the use (misuse?) of timers. It seems to me that a lot of times, the use of timers is not needed, as we can rely on the test runner timeout, and they become a source of flakiness. I could not agree more with this post from @Trott nodejs/node#5342 (comment). Should we set a position on this and maybe document it somewhere?
Metadata
Metadata
Assignees
Labels
No labels