Cleanup to prepare for a release #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested review from
refack,
jbergstroem,
sam-github and
rvagg
and removed request for
refack
cclauss
force-pushed
the
pre-release
branch
from
39c2b6a to
bab1b1c
Compare
cclauss
force-pushed
the
pre-release
branch
from
59a9120 to
a7a4eea
Compare
|
rubber stamp lgtm, I trust you to get this right |
sam-github
approved these changes
Sep 26, 2019
setup.py
Outdated
| 'Programming Language :: Python :: 3', | ||
| "Development Status :: 4 - Beta", | ||
| "Intended Audience :: Developers", | ||
| "License :: OSI Approved :: MIT License", |
There was a problem hiding this comment.
The License line shouldn't change, the others LGTM
jbergstroem
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherrypicks changes from #12 that are related to prepare the code for a release. Once this PR lands, #12 will be reworked to be a proper proposal for a release.