-
-
Notifications
You must be signed in to change notification settings - Fork 128
doc: first version of security releases process #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the [cve_management_process](https://github.com/nodejs/security-wg/blob/master/processes/cve_management_process.md). | ||
|
||
* Co-ordinate with the Release team members to line up one | ||
or more releasers to do the releases on the agreed date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given nodejs/node#21275 there should probably be an explicit step to notify the Build WG to ensure coverage to mitigate any infrastructure issues around the agreed date.
cc @nodejs/build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to what @richardlau said, can we also add a line saying that while the release is going out, the releaser must be around in node-build in case issues come up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* Create a PR to update the Node.js version in the official docker images. | ||
* Checkout the docker-node repo | ||
* Run the update.sh script to update versions | ||
* Update the changed files to **remove** all changes EXCEPT those which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chorrell is working on an update to the script allowing you to pass -s
which should make sure to just update the node version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB that's great I was thinking we wanted something to make that easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it's landed, so this part should probably be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
* In the docker-node repository run the | ||
[generate-stackbrew-library.sh]( https://github.com/nodejs/docker-node/blob/master/generate-stackbrew-library.sh) | ||
script and replace official-images/library/node with the output generated. | ||
* Open a PR with the changes to official-images/library/node making sure to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title of PR should include [security]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A right, I missed that this time.
processes/cve_management_process.md
Outdated
|
||
For each CVE listed, the additioanl data must include the following fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
``` | ||
* Move the CVE from the Pending section to the Announced section along | ||
with a link to the Node.js blog post announcing that releases | ||
are availble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Will leave a bit more time for review and them will incorporate changes so far. |
Believe I have addressed all of the comments. Going to land. |
PR-URL: nodejs/security-wg#306 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Liran Tal <liran.tal@gmail.com>
PR-URL: nodejs/security-wg#306 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Liran Tal <liran.tal@gmail.com>
No description provided.