Skip to content

doc: first version of security releases process #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 4, 2018

Conversation

mhdawson
Copy link
Member

No description provided.

the [cve_management_process](https://github.com/nodejs/security-wg/blob/master/processes/cve_management_process.md).

* Co-ordinate with the Release team members to line up one
or more releasers to do the releases on the agreed date.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given nodejs/node#21275 there should probably be an explicit step to notify the Build WG to ensure coverage to mitigate any infrastructure issues around the agreed date.

cc @nodejs/build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what @richardlau said, can we also add a line saying that while the release is going out, the releaser must be around in node-build in case issues come up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* Create a PR to update the Node.js version in the official docker images.
* Checkout the docker-node repo
* Run the update.sh script to update versions
* Update the changed files to **remove** all changes EXCEPT those which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chorrell is working on an update to the script allowing you to pass -s which should make sure to just update the node version.

nodejs/docker-node#784

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB that's great I was thinking we wanted something to make that easier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's landed, so this part should probably be updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

* In the docker-node repository run the
[generate-stackbrew-library.sh]( https://github.com/nodejs/docker-node/blob/master/generate-stackbrew-library.sh)
script and replace official-images/library/node with the output generated.
* Open a PR with the changes to official-images/library/node making sure to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title of PR should include [security]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A right, I missed that this time.


For each CVE listed, the additioanl data must include the following fields
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

```
* Move the CVE from the Pending section to the Announced section along
with a link to the Node.js blog post announcing that releases
are availble.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mhdawson
Copy link
Member Author

Will leave a bit more time for review and them will incorporate changes so far.

@mhdawson
Copy link
Member Author

mhdawson commented Jul 4, 2018

Believe I have addressed all of the comments. Going to land.

@mhdawson mhdawson merged commit 35bf0d8 into nodejs:master Jul 4, 2018
patrickm68 added a commit to patrickm68/security-wg-process that referenced this pull request Sep 14, 2023
 PR-URL: nodejs/security-wg#306
 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
 Reviewed-By: Liran Tal <liran.tal@gmail.com>
mattstern31 added a commit to mattstern31/security-wg-process that referenced this pull request Nov 11, 2023
 PR-URL: nodejs/security-wg#306
 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
 Reviewed-By: Liran Tal <liran.tal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants