-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Some Dependencies #54
base: main
Are you sure you want to change the base?
Conversation
After some hard work, I managed to (in my PR): Drop Dependencies (The main goal)
Little FixesThese just came up when I was updating the codebase
|
|
What is the reason for removing the development dependencies ( |
Oops! That must've been my bad, sorry! I'll fix it now |
why? using |
As far as I could tell, |
The latest commits allows the preview of the line to preview based on the autofill, similar to how nodejs does it. |
@devsnek, if you remember any other bugs, I can work on fixing them as well (if you don't mind) |
(and make some little changes)
If I find any other bug fixes, would you prefer I stash them locally and wait for this PR to be resolved, or just push them into this? |
Hi, @devsnek; sorry for bugging you (again), but how are you feeling about this PR. I'd love some feedback so I can make it (and my other PRs) better for the future! |
This PR drops a few dependencies to make this package smaller. This will help with the eventual movement to include this in NodeJS core.
This PR does NOT drop emphasize (5.5MB)
See nodejs/node#52510