feat: Add NodeJS to prohibited strings #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream PR to fix failure nodejs/node#33088 Can rebase this, or just squash and merge this when landing |
richardlau
approved these changes
Apr 27, 2020
Trott
reviewed
Apr 28, 2020
Trott
approved these changes
Apr 28, 2020
4 tasks
nschonni
force-pushed
the
nschonni-NodeJS-prohibited
branch
from
567846a to
a0b5d99
Compare
nschonni
force-pushed
the
nschonni-NodeJS-prohibited
branch
from
a0b5d99 to
cfd218d
Compare
|
@Trott had to undo the case change for the "N" since it then flagged all the github.com/nodejs links in comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this used to be in here, so maybe it was dropped for a reason. I think I've mostly seen this in the website content rather than the core