Skip to content

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Jul 7, 2021

Follow-up to #399. This PR fixes the below error, caused by recent versions of node adding a readonly promises property to the Stream constructor.

$ READABLE_STREAM=disable node
Welcome to Node.js v15.14.0.
Type ".help" for more information.
> var Readable = require('.')
Uncaught TypeError: Cannot set property promises of function Stream(opts) {
  EE.call(this, opts);
} which has only a getter
    at Function.assign (<anonymous>)
    at Object.<anonymous> (/home/ptaylor/dev/readable-stream/readable.js:4:10)
    at Module._compile (node:internal/modules/cjs/loader:1092:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Module.require (node:internal/modules/cjs/loader:996:19)
    at require (node:internal/modules/cjs/helpers:92:18)
> 

@trxcllnt
Copy link
Contributor Author

cc @mcollina because you helped review #399.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants