build for v6.1.0 #208
build for v6.1.0 #208
Conversation
lib/_stream_readable.js
Outdated
| encoding = encoding || state.defaultEncoding; | ||
| if (encoding !== state.encoding) { | ||
| chunk = new Buffer(chunk, encoding); | ||
| chunk = Buffer.from(chunk, encoding); |
There was a problem hiding this comment.
this doesn't work on older nodes right?
There was a problem hiding this comment.
yeah we're probably going to have to write a shim or polyfill
|
next up will be a fix for deepStrictEqual |
|
@calvinmetcalf any progress? Need any help? |
|
I need to port deepStrictEqual to work on all the platforms browserify/commonjs-assert#17 is not going as well as I'd hoped |
|
update looked like I found the problem, it was ArrayBuffer.isView |
|
and I should have been suspicious about all the file changes |
|
ok while we wait for @defunctzombie to review the changes to assert-commonjs we can test against my branch to make sure it actually fixes things |
|
@calvinmetcalf I've added you as collaborator to the commonjs-assert repo. I don't have much time for some of these projects these days and don't want to be a blocker. |
|
thanks! |
|
and got it working with browserify/commonjs-assert#18 |
calvinmetcalf
force-pushed
the
build-6.1.0
branch
2 times, most recently
from
725ad0f to
64e6bf3
Compare
calvinmetcalf
force-pushed
the
build-6.1.0
branch
from
64e6bf3 to
fe2de84
Compare
|
ok I've had all browsers pass, just not in the same run so screw it calling that green and going to publish |
4 participants
seems like the big changes are the new buffer api, plus that fix of mine for throwing on null chunks