cork()/uncork() and pipe()

[indutny]

It would be great if pipe() could somehow do cork()/uncork() to minimize amount of the TCP packets when piping to the net.Socket. Does anyone have an idea how to expose this to users? Or how to handle it?

Should we just cork and uncork on next tick as we do in http?

[calvinmetcalf]

something like https://github.com/calvinmetcalf/SBS ?

[indutny]

Yeah, but with ._writev call in the end. It is not currently possible to control this.

[indutny]

My use case is following (if you are interested). I have a protocol framer (say HTTP2), which is basically a readable stream. It emits frames in chunks (i.e. separate chunk for header, for body, sometimes more), and always does this synchronously (i.o.w. without delay between the chunks).

The owner of the framer pipes it into the socket, and now all of these pushes in framer result in separate TCP packets (especially when using noDelay), but it could potentially be just a single _writev call. I can do .cork()/.uncork() manually, but it will mean that I will need to reimplement .pipe() in my code.

[calvinmetcalf]

could be an option we could add to pipe

[indutny]

Oh, that sounds right! I forgot that .pipe() has options.

[trevnorris]

Why not auto cork on the initial write and queue a nextTick to uncork? Could be an option on the pipe, but the handling of packets is automated.

[indutny]

@trevnorris this is what I want :)

[calvinmetcalf]

@indutny nodejs/node#2020

[mcollina]

Closing now, as the PR has been debated and closed.