This repository was archived by the owner on Aug 11, 2020. It is now read-only.
doc,quic: update BigInt type to lowercase #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the doc target fails with the following error:
Error: Unrecognized type: 'BigInt'.
Please, edit the type or update the 'tools/doc/type-parser.js'.
at /quic/quic/tools/doc/type-parser.js:199:15
at Array.forEach (<anonymous>)
at Object.toLink (/quic/tools/doc/type-parser.js:175:13)
at /quic/quic/tools/doc/html.js:164:59
at Array.forEach (<anonymous>)
at linkJsTypeDocs (/quic/quic/tools/doc/html.js:163:19)
at /quic/tools/doc/html.js:111:23
This commit updates the types of BigInt to be lowercase which is how it
is defined in type-parser.js. I would have thought using 'BigInt' would
have been better but there might be a reason for this that I'm unware of
('bigint' is used in other files).
With this commit the build passes and I'll look into why this type is
lowercase and suggest fixing it in upstream/master.
jasnell
approved these changes
May 8, 2020
danbev
added a commit
that referenced
this pull request
May 8, 2020
Currently the doc target fails with the following error:
Error: Unrecognized type: 'BigInt'.
Please, edit the type or update the 'tools/doc/type-parser.js'.
at /quic/quic/tools/doc/type-parser.js:199:15
at Array.forEach (<anonymous>)
at Object.toLink (/quic/tools/doc/type-parser.js:175:13)
at /quic/quic/tools/doc/html.js:164:59
at Array.forEach (<anonymous>)
at linkJsTypeDocs (/quic/quic/tools/doc/html.js:163:19)
at /quic/tools/doc/html.js:111:23
This commit updates the types of BigInt to be lowercase which is how it
is defined in type-parser.js. I would have thought using 'BigInt' would
have been better but there might be a reason for this that I'm unware of
('bigint' is used in other files).
With this commit the build passes and I'll look into why this type is
lowercase and suggest fixing it in upstream/master.
PR-URL: #385
Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 5baab3f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the doc target fails with the following error:
This commit updates the types of BigInt to be lowercase which is how it
is defined in type-parser.js. I would have thought using 'BigInt' would
have been better but there might be a reason for this that I'm unware of
('bigint' is used in other files).
With this commit the build passes and I'll look into why this type is
lowercase and suggest fixing it in upstream/master.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes