This repository was archived by the owner on Aug 11, 2020. It is now read-only.
build: add quic build flag #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#145 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#150 Reviewed-By: James M Snell <jasnell@gmail.com>
Allow using the handle more directly for I/O in other parts of the codebase. PR-URL: nodejs#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
PR-URL: nodejs#138 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#138 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Move constructor and destructors for subclasses of `BaseObject` from node_crypto.h to node_crypto.cc. This removes the need to include base_object-inl.h when using node_crypto.h in some cases. PR-URL: nodejs#220 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: Anna Henningsen <anna@addaleax.net> Co-authored-by: Daniel Bevenius <daniel.bevenius@gmail.com> Co-authored-by: gengjiawen <technicalcute@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com> Co-authored-by: Ouyang Yadong <oyydoibh@gmail.com> Co-authored-by: Juan Jos<C3><A9> Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by: Denys Otrishko <shishugi@gmail.com>
|
Looks build failed on macOS: https://github.com/nodejs/quic/pull/345/checks?check_run_id=447809900. ../src/quic/node_quic_http3_application.cc:123:3: error: no matching member function for call to 'SetConfig'
SetConfig(IDX_HTTP3_QPACK_MAX_TABLE_CAPACITY,
^~~~~~~~~
../src/quic/node_quic_http3_application.cc:109:24: note: candidate template ignored: could not match 'unsigned long long' against 'unsigned long'
void Http3Application::SetConfig(
^
../src/quic/node_quic_http3_application.cc:125:3: error: no matching member function for call to 'SetConfig'
SetConfig(IDX_HTTP3_QPACK_BLOCKED_STREAMS,
^~~~~~~~~
../src/quic/node_quic_http3_application.cc:109:24: note: candidate template ignored: could not match 'unsigned long long' against 'unsigned long'
void Http3Application::SetConfig( |
gengjiawen
force-pushed
the
feature/CI
branch
from
be56990 to
1445167
Compare
|
For now likely best to set up separate work-flows that enable the flag |
jasnell
force-pushed
the
master
branch
4 times, most recently
from
928c50e to
08796cc
Compare
jasnell
force-pushed
the
master
branch
2 times, most recently
from
78e9941 to
cee2e5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure this should be merged, mainly want to test build on windows . Related: #344