ci: add executors for macOS and Windows #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgzr
requested changes
Sep 2, 2022
RaisinTen
requested changes
Sep 5, 2022
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
https://github.com/postmanlabs/postject/blob/6197192cd170ab1e776d8364fdda153b4abf7a54/build/system.mk#L12 is getting run on macOS - https://app.circleci.com/pipelines/github/postmanlabs/postject/17/workflows/5f82a544-609a-4f84-b63c-94e610819154/jobs/90?invite=true#step-104-3
uname: illegal option -- o
usage: uname [-amnprsv]That needs to be fixed.
Tests aren't run on Windows currently
Do you plan to run the tests on Windows before merging this PR?
Contributor
Author
Thanks, fixed.
Not in this PR, so it can be merged in a more timely manner. I don't think the Makefile for tests will be the long term solution so I'm not going to invest time in it for Windows and delay this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of rough edges in this PR but just trying to unblock:
defaultinstead ofbuild-win/default