Reimplement ELF support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robertgzr
commented
Jul 18, 2022
robertgzr
commented
- feat: implement elf support
- fix: use notes for elf implementation
assuming we only deal with un-stripped binaries Signed-off-by: Robert Günzler <r@gnzler.io>
Signed-off-by: Robert Günzler <r@gnzler.io>
jviotti
referenced
this pull request
in nodejs/single-executable
Aug 9, 2022
As pointed-out by @guest271314 in #8 (comment). Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
RaisinTen
approved these changes
Aug 17, 2022
Member
RaisinTen
left a comment
RaisinTen
left a comment
There was a problem hiding this comment.
LGTM. Further improvements can be done in other PRs, let's merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.