Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add 2023-04-03 meeting notes #69

Merged
merged 3 commits into from
Apr 11, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions meetings/2023-04-03.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# Node.js Performance Team Meeting 2023-04-03

## Links

* **Recording**: https://www.youtube.com/watch?v=MVqHVCv-rnQ
* **GitHub Issue**: https://github.com/nodejs/performance/issues/68

## Present

* Performance team: @nodejs/performance
* Yagiz Nizipli: @anonrig
* Stephen Belanger: @qard
* Robert Nagy: @ronag
* Debadree Chatterjee @debadree25


## Agenda

## Announcements

* Ada v2 is released. Announcement post is available at http://yagiz.co/announcing-ada-url-parser-v2-0/
* V8 11.3 brings `String.prototype.toWellFormed()` support with 70-80% faster `toUSVString`
anonrig marked this conversation as resolved.
Show resolved Hide resolved
* Increasing the default watermark size for version 20. It provides a performance boost!
anonrig marked this conversation as resolved.
Show resolved Hide resolved

*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/performance

* add/remove handlers are slow on EventTarget [#60](https://github.com/nodejs/performance/issues/60)
* It would be great to add a fast path for AbortSignal to have only one AbortController.
* There are no other works on it right now.
* Debadree attempted on adding a hashmap based approach but did not help with any performance impacts.
* It would be great to have a benchmark for adding and removing a single event listener (the current benchmarks adds and removes multiple benchmarks), because the proposed benchmark would never traverse the linkedlist.
anonrig marked this conversation as resolved.
Show resolved Hide resolved
* Session proposals for the next Collaborator Summit - what should we submit [#64](https://github.com/nodejs/performance/issues/64)
* Bun & Deno Comparison [#55](https://github.com/nodejs/performance/issues/55)
* Yagiz proposed adding his own performance benchmarks to the performance repository. Will keep this for visibility.
* AbortSignal pattern is slow [#44](https://github.com/nodejs/performance/issues/44)
* Closing it since it is a duplicate of add/remove handlers for EventTarget
* Module resolution [#39](https://github.com/nodejs/performance/issues/39)
* Put this on hold until off-thread loader pull request is landed.
* EventTarget [#32](https://github.com/nodejs/performance/issues/32)
* Closing it due to Santiago’s amazing contributions.
* fetch [#11](https://github.com/nodejs/performance/issues/11)
* Robert: I don’t know where to start optimizing. There’s more work to be done. Maybe we can ask Rafael on making a new analysis on undici fetch?
RafaelGSS marked this conversation as resolved.
Show resolved Hide resolved


## Q&A, Other

## Upcoming Meetings

* **Node.js Foundation Calendar**: https://nodejs.org/calendar

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.