Skip to content

Performance regression Date.toISOString() #47

Description

@RafaelGSS

These are the last results of nodejs-bench-operations

and as you can see, toISOString might have been affected by a regression.

Activity

  1. RafaelGSS commented on Jan 27, 2023

    @RafaelGSS
    MemberAuthor

    And it seems to be there since v19.3.0 (at least) https://github.com/RafaelGSS/nodejs-bench-operations/tree/main/v19.

  2. anonrig commented on Feb 3, 2023

    @anonrig
    Member

    We updated to V8 10.8 in v19.3.0. Could this be related?

    [c8421204b0] - deps: patch V8 to 10.8.168.21 (Michaël Zasso) nodejs/node#45749

  3. RafaelGSS commented on Feb 3, 2023

    @RafaelGSS
    MemberAuthor

    No. This was caused by a semver-major change. I've adjusted the repository to run the benchmark against 18.0.0 and 19.0.0 and the regression is still there.

  4. targos commented on Feb 4, 2023

    @targos
    Member

    It's probably the update to V8 10.7

  5. targos commented on Feb 4, 2023

    @targos
    Member

    Implementation of toISOString was changed in v8/v8@126d477

  6. anonrig commented on Feb 9, 2023

    @anonrig
    Member

    Is there an open issue in the V8 bug tracker for this?

  7. targos commented on Feb 11, 2023

    @targos
    Member

    probably not

  8. anonrig commented on Apr 3, 2023

    @anonrig
    Member

    Is the regression still there with V8 11.3? @RafaelGSS

  9. ronag commented on May 30, 2023

    @ronag
    Member

    I don't think this is actionable?

  10. RafaelGSS commented on May 30, 2023

    @RafaelGSS
    MemberAuthor

    Yeah, it's more of a tracking issue in case someone wants to fix it in the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions