Conversation
…nd refine viewport configuration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8606 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 103 103
Lines 9062 9062
Branches 312 312
=======================================
Hits 6800 6800
Misses 2260 2260
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR standardizes responsive breakpoints across the site by replacing the custom xs breakpoint (670px) with a new ml (medium-large) breakpoint at 896px, and updating related responsive layouts to use larger breakpoint thresholds. The changes also modernize CSS utilities and improve mobile viewport configuration.
Changes:
- Replaced
xsbreakpoint (670px) withmlbreakpoint (896px) throughout the codebase - Updated responsive layouts to transition at larger screen sizes (sm→ml, lg→xl for various components)
- Added new container sizes (8xl through 12xl) and a 3xl breakpoint (120rem) to theme configuration
- Modernized spacing syntax from Tailwind CSS v3
theme()to v4--spacing()notation - Improved viewport accessibility by removing
maximumScalerestriction
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/styles/theme.css | Added new container sizes (8xl-12xl), ml and 3xl breakpoints; removed xs breakpoint and max-w-8xl utility |
| packages/ui-components/src/styles/markdown.css | Updated link and code styling to use ml breakpoint instead of xs |
| packages/ui-components/src/Containers/Sidebar/index.module.css | Changed sidebar visibility and layout breakpoints from sm/md to ml, updated padding breakpoint from lg to 2xl |
| packages/ui-components/src/Containers/NavBar/index.module.css | Updated navigation bar responsive layout from lg to xl breakpoint |
| packages/ui-components/src/Containers/MetaBar/index.module.css | Changed overflow-wrap property to wrap-anywhere utility and updated link styling to ml breakpoint |
| packages/ui-components/src/Containers/Footer/index.module.css | Updated footer link styling to use ml breakpoint |
| packages/ui-components/src/Containers/Article/index.module.css | Refactored grid layout with ml and xl breakpoints, updated spacing syntax to v4 notation, changed max-width from 8xl to 10xl |
| packages/ui-components/src/Common/Modal/index.module.css | Updated modal padding breakpoint from xs to ml |
| packages/ui-components/src/Common/Breadcrumbs/BreadcrumbRoot/index.module.css | Changed breadcrumb width breakpoint from xs to ml |
| packages/ui-components/src/Common/AvatarGroup/Avatar/index.module.css | Updated avatar sizing breakpoints from xs to ml |
| packages/ui-components/package.json | Bumped version from 1.5.8 to 1.5.9 |
| apps/site/pages/*/index.mdx (8 files) | Updated partner list margin breakpoint from xs to ml across all locale home pages |
| apps/site/next.dynamic.constants.mjs | Changed viewport initialScale format and removed maximumScale for better accessibility |
| apps/site/layouts/layouts.module.css | Updated layout breakpoints and spacing syntax, changed overflow-wrap to wrap-anywhere |
| apps/site/components/withBlogCrossLinks.tsx | Updated grid column breakpoint from xs to ml |
| apps/site/components/withBlogCategories.tsx | Updated blog category grid breakpoint from xs to ml |
| apps/site/components/Releases/MinorReleasesTable/index.module.css | Updated table border breakpoints from xs to ml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (1)
➖ Removed Assets (1)
|
|
Imma gonna fast-track this as bug fixes which they are (bug fix fast-tracks don't require fast-track approval) Please feel free to review afterwards if you find any issue. |
|
Reminder - fast tracking needs a 👍 from someone else, if you are the PR author |
This PR makes a few CSS "fixes" by improving scrollbars, viewport sizes, the grid format for different viewports in some layouts, etc.
You can compare the Learn, About and Blog Post changes as those would have effectively the differences.
This PR should improve viewing in small screens, medium screens, large and extra large screens.