-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(AlertBox): override code styles in a markdown context #7890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the reliance on inherited text color for inline code
elements to prevent unreadable white text in light contexts.
- Eliminates the
text-inherit
utility oncode
within markdown styles to allow explicit coloring. - Ensures code blocks can receive their own color rules rather than inheriting from parent.
Comments suppressed due to low confidence (1)
packages/ui-components/styles/markdown.css:92
- Removing the inherited text color means code elements may not have sufficient contrast by default; consider adding an explicit color utility (e.g.,
text-neutral-900 dark:text-neutral-100
) to ensure readability across themes.
dark:max-xs:decoration-neutral-200;
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
==========================================
- Coverage 75.47% 75.46% -0.02%
==========================================
Files 101 101
Lines 8311 8311
Branches 218 218
==========================================
- Hits 6273 6272 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
a
28fd545
to
2668054
Compare
2668054
to
24be41c
Compare
a
a > code
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
a > code
1f9025f
to
2a4c511
Compare
2a4c511
to
2f18159
Compare
In the Figma, there isn't a font change in |
Description
When the inherited text is white, the

code
element does not have a readable contrast, as shown below:Validation
Everything on the website should look identical, but this should make a readable contrast on
api-docs-tooling
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.