Skip to content

chore(homepage): link to our blog, rather than HeroDevs #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jun 22, 2025

This PR proposes a quick improvement to the current homepage button that directly links to HeroDev's website.

It’s based on a suggestion by @joyeecheung to provide a clearer, more official announcement link.

cc @nodejs/tsc

Relates to #7773

Signed-off-by: Claudio W. <cwunder@gnome.org>
@Copilot Copilot AI review requested due to automatic review settings June 22, 2025 16:15
@ovflowd ovflowd requested a review from a team as a code owner June 22, 2025 16:15
Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 22, 2025 4:37pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the homepage’s secondary button to point to the official Node.js announcement for Node.js 18 EOL support instead of the external HeroDevs page.

  • Replaced HeroDevs support link with Node.js blog announcement URL
  • Button text and styling remain unchanged

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (2fc6472) to head (4360625).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7883      +/-   ##
==========================================
+ Coverage   75.45%   75.47%   +0.02%     
==========================================
  Files         101      101              
  Lines        8311     8311              
  Branches      218      218              
==========================================
+ Hits         6271     6273       +2     
+ Misses       2038     2036       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller requested a review from a team June 22, 2025 16:20
@avivkeller
Copy link
Member

I pre-emptively approve a future fast-track request under the condition that this receives TSC approval.

@avivkeller avivkeller changed the title chore; moves the link from herodevs to our ESP blog post chore(homepage): link to our blog, rather than HeroDevs Jun 22, 2025
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the red X on this to make sure it doesn't land without the TSC having the opportunity to discuss further. The change itself lgtm but we need to be clear on the intent and goal here. Linking to something other than directly to the Herodevs site might be contrary to the entire point.

@anonrig
Copy link
Member

anonrig commented Jun 22, 2025

Cc @nodejs/tsc please review

@ovflowd
Copy link
Member Author

ovflowd commented Jun 22, 2025

Dropping the red X on this to make sure it doesn't land without the TSC having the opportunity to discuss further. The change itself lgtm but we need to be clear on the intent and goal here. Linking to something other than directly to the Herodevs site might be contrary to the entire point.

Thanks for calling that out. My goal here was to help reduce the heat and confusion we're currently getting from parts of the community regarding the presence of a direct link to a 3rd-party site.

This change is meant as a temporary measure — or potentially a longer-term solution, if it ends up being seen as a better compromise. I agree that we should align on the broader goals here, but I believe this could help ease some of the current friction in the meantime.

Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Claudio W. <cwunder@gnome.org>
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it !

@avivkeller
Copy link
Member

avivkeller commented Jun 22, 2025

@jasnell you blocked, but you also 👍 the rationale @ovflowd explained, so do you rescind your block? (just want to clarify)

@jasnell
Copy link
Member

jasnell commented Jun 22, 2025

No, I explained why I blocked and that still stands. I want to make sure there's plenty of time for the TSC and Foundation to discuss.

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this was what I would've felt more comfortable with in the first place, I think in terms of protecting the image of the project this is a strict improvement (I am already seeing criticism about the current direct link on social media, both towards the project and towards the sponsor. Directing to an official blog post at least does enough as damage control).

@jasnell
Copy link
Member

jasnell commented Jun 22, 2025

Would you be willing to link to any criticisms you've seen? Given that one of the purposes of the link was to determine how effective such a link would be, such concrete feedback would be helpful.

I've not seen any public criticism in social channels yet.

@joyeecheung
Copy link
Member

I don't feel like adding a GitHub <-> social media feedback loop since that seems somewhat toxic, I will post it to the nodejs-social slack channel.

@MattIPv4
Copy link
Member

MattIPv4 commented Jun 22, 2025

👀 If/when this is given TSC approval, we should also make sure we have explicit approval from the Foundation for this change, as I understand it was a request from them to have this be a direct link rather than to our blog post.

(I am very much +1 to this change, I think a first-party link that educates on EOL status, updating, etc. and gives context before sending users to the ESP is much more valuable to the community than a direct link to the ESP with very little context, but want to make sure we're fully aligned on this change and aren't falling foul of any requirements from the Foundation.)

@ljharb
Copy link
Member

ljharb commented Jun 23, 2025

Personally I think having a distinct page on nodejs.org that describes the ESP specifically, and then in turn links to partners (HeroDevs at the moment, but obviously any additional partners in the future), would be a perfectly fine choice here - but a blog post where commercial support is mentioned in the 16th-18th paragraphs doesn't seem like it will move the needle for getting funding for the project, nor satisfy the ESP contract terms.

@joyeecheung
Copy link
Member

joyeecheung commented Jun 23, 2025

doesn't seem like it will move the needle for getting funding for the project, nor satisfy the ESP contract terms.

Are we on a program different from what Vue.js is doing? Can that page be tweaked to be similar to https://v2.vuejs.org/eol/ and to be enough?

I wonder where can we find the ESP contract, is that public, or at least the terms about promotional content? I did see some numbers that the project is getting but it was communicated in a private meeting, which was somewhat confusing to me - at the end of the day the project is a community-driven one and the foundation is a 501c3 (EDIT: apparently it's now 501c6), the TSC isn't in any contractual relationship and is just a subset of collaborators that also act as custodians of the project. I am not sure why the TSC needed to see the numbers in private since it's not the TSC getting paid. And only showing it briefly at a meeting makes it difficult to look up later. It was also communicated to the TSC that the button is vital for the CI infrastructure staff hours that the OpenJSF hires from LF and the project relies on and at least for me that was why I didn't want to die on the hill on this.

I feel that the amount of information being kept in private is more than necessary or counterproductive to make the program successful. If our collective goal is to keep enough traffic to the sponsor so that we have enough income for the CI infra to stay afloat, why not just disclose the traffic and the income, and we collectively work towards that goal in public? I think that might even be some positive publicity from this for the sponsor, instead of leaving people guessing what this whole program is about and assuming bad faith on social media.

@ovflowd
Copy link
Member Author

ovflowd commented Jun 23, 2025

Are we on a program different from what Vue.js is doing? Can that page be tweaked to be similar to https://v2.vuejs.org/eol/ and to be enough?

My exact thoughts. I could also set a permanent URL for /eol (FYI); But I'm also curious on why Vue can have a blog post and us not? To be clear, I'm fine having a dedicated "page" which honestly speaking can just be a blog post. I also thought that @rginn did write the blog post (and Matteo posted on her behalf); I'm also 👍 if we want to rephrase or update the blog post to better align with any contractaul terms.

@ljharb
Copy link
Member

ljharb commented Jun 23, 2025

I haven't even seen the contract, fwiw; I'd reach out to @rginn with questions about that.

https://v2.vuejs.org/eol/ is perfect for vue 2, but node likely doesn't want to make a page like that for each EOL release line - I think linking to https://nodejs.org/en/about/previous-releases#commercial-support (and linking to this blog post from there) might work though?

@ovflowd
Copy link
Member Author

ovflowd commented Jun 23, 2025

@jasnell apologies for me bothering you again, due to #7773 (comment) the button itself lost its value. I do believe we should merge this, otherwise the button is just simply not there for anyone using EasyList, which is incorporated on pretty much every AdBlocker be it browser-level or DNS level.

@ljharb
Copy link
Member

ljharb commented Jun 23, 2025

I think you're vastly overestimating how many people use adblockers, especially in enterprise environments - I don't think its targeting by adblockers reduces its value at all, personally.

@avivkeller
Copy link
Member

avivkeller commented Jun 23, 2025

I think you're vastly overestimating how many people use adblockers, especially in enterprise environments - I don't think its targeting by adblockers reduces its value at all, personally.

  1. Are we? Ad blockers are extremely popular. Per multiple sources, roughly a third of internet users use an adblocker. (https://backlinko.com/ad-blockers-users)

  2. “But the enterprise users”, in my opinion, isn’t a valid argument because enterprise environments don’t operate in a vacuum. Many purchasing decisions are influenced by research done outside of locked-down work environment.

@ovflowd
Copy link
Member Author

ovflowd commented Jun 23, 2025

I think you're vastly overestimating how many people use adblockers, especially in enterprise environments – I don't think its targeting by adblockers reduces its value at all, personally.

As an enterprise user myself, I do use an adblocker. Do you have any data to support your claim? Specifically, can you provide statistics on what percentage of users accessing nodejs.org are doing so from enterprise or work environments?

With all due respect, if major privacy filter lists are blocking the button, that alone significantly undermines its visibility and, by extension, its effectiveness.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.