feat: use localName in dropdown #7337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/site/components/Common/LanguageDropDown/index.tsx:50
- Ensure that the change to display
localNameinstead ofnamein the dropdown is covered by unit tests to verify that the correct names are displayed.
{localName}
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Dec 18, 2024
|
Why there are a regression on code cov ? |
aymen94
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking at https://www.electronjs.org/ and realized that our localization dropdown is all in English.
This isn't quite useful to native speakers
Validation
https://nodejs-org-git-use-localname-openjs.vercel.app/
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.