Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v21.0.0 Release #6022

Merged
merged 6 commits into from
Oct 17, 2023
Merged

v21.0.0 Release #6022

merged 6 commits into from
Oct 17, 2023

Conversation

RafaelGSS
Copy link
Member

No description provided.

@RafaelGSS RafaelGSS requested a review from a team as a code owner October 17, 2023 16:06
@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 4:29pm

RafaelGSS
RafaelGSS commented Oct 17, 2023
View reviewed changes
pages/en/blog/release/v21.0.0.md Outdated Show resolved Hide resolved
pages/en/blog/release/v21.0.0.md Outdated Show resolved Hide resolved
@RafaelGSS

This comment was marked as resolved.

Sign in to view
@RafaelGSS RafaelGSS mentioned this pull request Oct 17, 2023
Closed
@RafaelGSS RafaelGSS requested a review from a team as a code owner October 17, 2023 16:10
@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

@RafaelGSS I reran the script locally and the parts that are missing for you are filled for me. Can you please checkout latest main and rerun?

richardlau
richardlau reviewed Oct 17, 2023
View reviewed changes
pages/en/blog/release/v21.0.0.md Outdated Show resolved Hide resolved
pages/en/blog/release/v21.0.0.md Outdated Show resolved Hide resolved
@RafaelGSS
Copy link
Member Author

@RafaelGSS I reran the script locally and the parts that are missing for you are filled for me. Can you please checkout latest main and rerun?

Done, it seems to work! Thanks. PR ready to review/merge.

richardlau
richardlau reviewed Oct 17, 2023
View reviewed changes
site.json Outdated Show resolved Hide resolved
@MattIPv4
Copy link
Member

@ovflowd Could you take a look at why Vercel failed to deploy?

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@richardlau richardlau added the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 96%
 95% (285/300) 76.81% (53/69) 93.33% (56/60)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 8.088s ⏱️

@richardlau
Copy link
Member

richardlau commented Oct 17, 2023 •
edited
Loading

@ovflowd Could you take a look at why Vercel failed to deploy?

I redeployed. FWIW it looks like a build step got truncated JSON.

> nodejs.org@1.0.0 scripts:generate-next-data
> cross-env NODE_NO_WARNINGS=1 node scripts/generate-next-data/index.mjs
- info (blog-posts-data.json) and (node-releases-data.json) got generated.
undefined:706
{"version":"v0.1.18","date":"2011-08-26","
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at parseJSONFromBytes (node:internal/deps/undici/undici:6662:19)
    at successSteps (node:internal/deps/undici/undici:6636:27)
    at node:internal/deps/undici/undici:1236:60
    at node:internal/process/task_queues:140:7
    at AsyncResource.runInAsyncScope (node:async_hooks:203:9)
    at AsyncResource.runMicrotask (node:internal/process/task_queues:137:8)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Node.js v18.17.1
Error: Command "npm run build" exited with 1

@RafaelGSS RafaelGSS added this pull request to the merge queue Oct 17, 2023
ovflowd
ovflowd reviewed Oct 17, 2023
View reviewed changes
pages/en/blog/announcements/v21-release-announce.md
After this PR everything is combined into a single chunk when uncorking the response bypassing a
lot of unnecessary overhead.

HTTP/1.1 200 OK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Blocks should be fenced :d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question in #6022 (comment)

Copy link
Member Author

@RafaelGSS RafaelGSS Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried locally and it just worked

image

@ovflowd
Copy link
Member

ovflowd commented Oct 17, 2023

@ovflowd Could you take a look at why Vercel failed to deploy?

Node.js CDN getting hammered crazy

Merged via the queue into main with commit aed5386 Oct 17, 2023
19 of 20 checks passed
@RafaelGSS RafaelGSS deleted the v21-release branch October 17, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd left review comments

@richardlau richardlau richardlau approved these changes

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelGSS @ovflowd @MattIPv4 @richardlau