Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point to MDN for arguments object article #4385

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 26, 2022

Send readers from the arguments object knowledge base article to the MDN
article on the topic. This also removes some sample code that was
broken.

Closes: #4384

Send readers from the arguments object knowledge base article to the MDN
article on the topic. This also removes some sample code that was
broken.

Closes: nodejs#4384
@Trott Trott enabled auto-merge (squash) January 26, 2022 12:08
@Trott Trott merged commit c8209f2 into nodejs:main Jan 27, 2022
@Trott Trott deleted the args branch January 27, 2022 05:41
@lxmarinkovic
Copy link
Contributor

Hi @Trott , I need to join 18n, but it looks like I need an invite to @nodejs first. Could you help

@Trott
Copy link
Member Author

Trott commented Jan 31, 2022

Hi @Trott , I need to join 18n, but it looks like I need an invite to @nodejs first. Could you help

Why do you say you need to join i18n?

@lxmarinkovic
Copy link
Contributor

lxmarinkovic commented Feb 1, 2022 via email

@Trott
Copy link
Member Author

Trott commented Feb 1, 2022

Hi @Trott , thank you for the quick reply. I posted an issue nodejs/i18n#612 with my reasons to join i18n, and it is mainly because I feel that as a professional software engineer that is using this technology for more than ten years, should use free time to contribute, making it more accessible to the non-English speaking/writing crowd Wish you a nice day ahead! 🗡️

Hi @lxmarinkovic. If you want to create Serbian translations, you can open pull requests against this repository, creating files in locale/sr. I'm not sure where things are at with i18n and CrowdIn, but we'll see what people say in that other issue.

@lxmarinkovic
Copy link
Contributor

Thank you, @Trott , I'll do that, and also the reason why I would like to become of node.js org is willing to invest some free time in evangelism and education with a Node.js Stockholm meetup group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting mistake at "What is the arguments object?" page
3 participants