main.js: remove ancient versions code #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
May 4, 2021
| @@ -198,12 +198,6 @@ | |||
| for (var i = 0; i < linkEls.length; i++) { | |||
There was a problem hiding this comment.
Personally I'd change this to a forEach since it's shorter, but maybe later.
There was a problem hiding this comment.
In fact it does no obvious performance improvement, so I think this can be changed later :)
MrJithil
approved these changes
May 4, 2021
SEWeiTung
approved these changes
Jul 16, 2021
|
Can this be merged or leave it alone for old versions? |
aymen94
approved these changes
Nov 26, 2021
XhmikosR
force-pushed
the
XhmikosR-patch-2
branch
from
8f384ca to
8c4f123
Compare
SEWeiTung
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove ancient versions code.