Skip to content

Conversation

@SEWeiTung
Copy link
Contributor

@SEWeiTung SEWeiTung commented Feb 14, 2021

"Metal-Prism" needs a range of coding languages to be rendered with, however the script will generate some languages that don't match what it really needs. This is a fixture for it.

For more, please see: #3695.

@SEWeiTung SEWeiTung requested review from XhmikosR and targos February 14, 2021 16:22
@XhmikosR XhmikosR changed the title fixture of rendering error in Prism Fix rendering error in Prism Feb 14, 2021
@XhmikosR
Copy link
Contributor

XhmikosR commented Feb 14, 2021

You could probably add a new CHANGELOG.md file with a few lines instead of 1.6K lines :)

EDIT: or even just add a new section in the existent changelog file? Not sure what's the procedure.

"Metal-Prism" needs a range of coding languages to be rendered with,
however the script will generate some languages that don't match what it
really needs. This is a fixture for it.

For more, please see: #3695.
@SEWeiTung
Copy link
Contributor Author

You could probably add a new CHANGELOG.md file with a few lines instead of 1.6K lines :)

EDIT: or even just add a new section in the existent changelog file? Not sure what's the procedure.

Good idea, I just keep the content to be mocked for test.

@SEWeiTung SEWeiTung requested a review from Trott February 15, 2021 02:20
@SEWeiTung SEWeiTung requested review from a team and XhmikosR and removed request for Trott, XhmikosR and targos February 16, 2021 08:20
@SEWeiTung SEWeiTung changed the title Fix rendering error in Prism fixture of rendering error of "console" in Prism Feb 21, 2021
@SEWeiTung SEWeiTung merged commit 06bd5fc into nodejs:master Feb 23, 2021
@SEWeiTung SEWeiTung deleted the fixPrismRenderingErr branch February 23, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants